chore: ansible-lint review (almost done)

roles/nfs_server/README.md

@@ -0,0 +1,38 @@
+# NFS Server
+
+This configuration is meant to be simple. We do not use a keberos server, nor fine-grained user ACLs here. I try not to mess up with ZFS options either.
+
+Security is only guaranteed by the network (and firewal). Security is based on the IP address of the client, so I suggest to use a VPN if you want to avoid ARP poisoning on your LAN.
+
+## In a nutshell
+
+**Supports:**
+
+- NFSv4 (TCP/UDP)
+- UFW firewal configuration
+- Reload service and exportfs on configuration change
+
+**Limitations:**
+
+- Access control limited to the IP address of the client (unsecure)
+
+## Inventory
+
+Example of `nfs_shares` you can declare:
+
+```yaml
+nfs_shares:
+    - dir: "/srv/nfs/photos"
+      clients:
+          - host: "192.168.1.100" # privileged user with write a access
+            options: "rw,sync,no_subtree_check,all_squash,anonuid=1000,anongid=1000,insecure"
+          - host: "192.168.1.0/24" # readonly access for other lan clients
+            options: "ro,sync,no_subtree_check"
+```
+
+> Note: to make the share accessible from MacOS, you might use the `insecure` option (allowing to bind port numbers > 1024).
+
+## Ressources
+
+- https://wiki.archlinux.org/title/NFS
+- https://www.fkylewright.com/wordpress/2023/06/functional-automount-of-network-shares-in-macos/

roles/nfs_server/defaults/main.yml

@@ -0,0 +1,18 @@
+---
+# Example:
+# nfs_shares:
+#   - dir: "/srv/nfs/photos"
+#     clients:
+#       - host: "192.168.1.100" # privileged user with write a access
+#         options: "rw,sync,no_subtree_check,all_squash,anonuid=1000,anongid=1000,insecure"
+#       - host: "192.168.1.0/24" # readonly access for other lan clients
+#         options: "ro,sync,no_subtree_check"
+nfs_shares: []
+nfs_configuration_file: "/etc/nfs.conf"
+
+nfs_exports_file: "/etc/exports"
+
+nfs_port: 2049
+
+nfs_server_firewall_allowed_sources:
+  - 127.0.0.0/8

roles/nfs_server/handlers/main.yml

@@ -0,0 +1,9 @@
+---
+- name: "Reload systemd and restart nfs-server"
+  ansible.builtin.systemd:
+    name: "nfsv4-server"
+    state: restarted
+    daemon_reload: true
+
+- name: "Update exportfs"
+  ansible.builtin.command: exportfs -ra

roles/nfs_server/tasks/main.yml

@@ -0,0 +1,43 @@
+---
+- name: Install nfs-server
+  ansible.builtin.package:
+    name: "{{ (ansible_facts['os_family'] == 'Archlinux') | ternary('nfs-utils', 'nfs-kernel-server') }}"
+    state: present
+
+- name: Configure nfs configuration
+  ansible.builtin.template:
+    src: templates/nfs.conf.j2
+    dest: "{{ nfs_configuration_file }}"
+    owner: root
+    group: root
+    mode: "0644"
+  notify: Reload systemd and restart nfs-server
+
+- name: Configure nfs-server exports
+  ansible.builtin.template:
+    src: templates/exports.j2
+    dest: "{{ nfs_exports_file }}"
+    owner: root
+    group: root
+    mode: "0644"
+  notify: Update exportfs
+
+- name: Systemd service for nfs-server is started and enabled
+  ansible.builtin.systemd:
+    name: nfsv4-server
+    state: started
+    enabled: true
+
+- name: Setup firewall rules for nfs on port
+  community.general.ufw:
+    rule: allow
+    src: "{{ item }}"
+    port: "{{ nfs_port }}"
+    proto: any
+    direction: in
+    comment: "Network File System (NFS)"
+  with_items: "{{ nfs_server_firewall_allowed_sources | default([]) }}"
+  retries: 5
+  delay: 2
+  register: ufw_result
+  until: ufw_result is succeeded

roles/nfs_server/templates/exports.j2

@@ -0,0 +1,8 @@
+# {{ ansible_managed }}
+#
+
+{% for share in nfs_shares %}
+{% for client in share.clients %}
+{{ share.dir }} {{ client.host }}({{ client.options }})
+{% endfor %}
+{% endfor %}

roles/nfs_server/templates/nfs.conf.j2

@@ -0,0 +1,4 @@
+[nfsd]
+{% for ip in nfs_bind_addresses %}
+host={{ ip }}
+{% endfor %}