fix(nginx): make Let's Encrypt opt-in per service

certbot cannot issue for internal hostnames (*.nas.local), which made
nginx-enabled services with internal names fail on deploy.

Add a <service>_nginx_letsencrypt flag (default false) and computed
<service>_nginx_ssl_certificate/_key paths: when off the vhost uses the
shared self-signed cert (nginx_default_ssl_cert), when on it uses the
Let's Encrypt lineage. Gate the certbot include on the flag and apply the
pattern to all service roles (deluge, fdroid, gitea, grafana, immich,
metabase, ntfy, prowlarr, radarr, seerr, static_web, uptime_kuma).

roles/ntfy/defaults/main.yml

@@ -43,3 +43,16 @@ ntfy_enable_reservations: true # Only authenticated users can reserve topics
 # Nginx reverse proxy configuration
 ntfy_nginx_enabled: false
 ntfy_nginx_hostname: ntfy.nas.local
+# Let's Encrypt (certbot) requires a publicly-resolvable hostname. Internal
+# names (e.g. *.nas.local) cannot get a public cert: leave this false to use
+# the shared self-signed cert (nginx_default_ssl_cert). Set true once a public
+# DNS record points at the host.
+ntfy_nginx_letsencrypt: false
+ntfy_nginx_ssl_certificate: >-
+  {{ ntfy_nginx_letsencrypt | ternary(
+     '/etc/letsencrypt/live/' ~ ntfy_nginx_hostname ~ '/fullchain.pem',
+     nginx_default_ssl_cert) }}
+ntfy_nginx_ssl_certificate_key: >-
+  {{ ntfy_nginx_letsencrypt | ternary(
+     '/etc/letsencrypt/live/' ~ ntfy_nginx_hostname ~ '/privkey.pem',
+     nginx_default_ssl_key) }}

roles/ntfy/tasks/main.yml

@@ -147,7 +147,7 @@
   ansible.builtin.include_tasks: "{{ role_path }}/../nginx/tasks/certbot.yml"
   vars:
     certbot_hostname: "{{ ntfy_nginx_hostname }}"
-  when: ntfy_nginx_enabled
+  when: ntfy_nginx_enabled and ntfy_nginx_letsencrypt
 
 - name: Deploy nginx vhost configuration for ntfy
   ansible.builtin.template:

roles/ntfy/templates/nginx-vhost.conf.j2

@@ -22,9 +22,8 @@ server {
     listen [::]:443 ssl;
     server_name {{ ntfy_nginx_hostname }};
 
-    # Let's Encrypt certificates (managed by Certbot)
-    ssl_certificate /etc/letsencrypt/live/{{ ntfy_nginx_hostname }}/fullchain.pem;
-    ssl_certificate_key /etc/letsencrypt/live/{{ ntfy_nginx_hostname }}/privkey.pem;
+    ssl_certificate {{ ntfy_nginx_ssl_certificate }};
+    ssl_certificate_key {{ ntfy_nginx_ssl_certificate_key }};
 
     # SSL configuration
     ssl_protocols {{ nginx_ssl_protocols | default('TLSv1.3') }};