chore: ansible-lint

roles/disks/tasks/main.yml

@@ -1,7 +1,7 @@
 ---
 - name: Ensure disks are formatted correctly
-  include_tasks: partitioning.yml
+  ansible.builtin.include_tasks: partitioning.yml
   loop: "{{ disk_partitioning | default([]) }}"
 
 - name: Enable trim SSD if there is at least one
-  include_tasks: trim-ssd.yml
+  ansible.builtin.include_tasks: trim-ssd.yml

roles/disks/tasks/partitioning.yml

@@ -1,23 +1,23 @@
 ---
 - name: Install sfdisk
-  package:
+  ansible.builtin.package:
     name: util-linux
     state: present
   changed_when: false
 
 - name: Install hdparm
-  package:
+  ansible.builtin.package:
     name: hdparm
     state: present
   changed_when: false
 
 - name: Load expected layout from file (controller side)
-  set_fact:
+  ansible.builtin.set_fact:
     expected_layout: "{{ lookup('file', item.layout_file) }}"
   changed_when: false
 
 - name: Get current layout from remote
-  command: "sfdisk --dump {{ item.device }}"
+  ansible.builtin.command: "sfdisk --dump {{ item.device }}"
   register: current_layout
   changed_when: false
 
@@ -25,18 +25,18 @@
   vars:
     current_clean: "{{ current_layout.stdout | trim | regex_replace('\\s+', ' ') }}"
     expected_clean: "{{ expected_layout | trim | regex_replace('\\s+', ' ') }}"
-  set_fact:
+  ansible.builtin.set_fact:
     layout_differs: "{{ current_clean != expected_clean }}"
   changed_when: false
 
 - name: Copy layout file to remote (only if different)
-  copy:
+  ansible.builtin.copy:
     content: "{{ expected_layout }}"
     dest: "/tmp/expected-{{ item.device | basename }}.sfdisk"
     mode: "0644"
   when: layout_differs
 
 - name: Apply partition table using sfdisk
-  command: >
+  ansible.builtin.command: >
     sfdisk {{ item.device }} < {{ item.layout_file }}
   when: layout_differs

roles/disks/tasks/trim-ssd.yml

@@ -1,22 +1,22 @@
 ---
 # see: https://wiki.archlinux.org/title/Solid_state_drive#Periodic_TRIM
 - name: Check if there is at least one SSD
-  set_fact:
-    has_at_least_one_ssd: "{{ ansible_facts.devices | dict2items | selectattr('value.rotational', 'equalto', '0') | list | length > 0}}"
+  ansible.builtin.set_fact:
+    has_at_least_one_ssd: "{{ ansible_facts.devices | dict2items | selectattr('value.rotational', 'equalto', '0') | list | length > 0 }}"
   changed_when: false
 
 - name: Skip trim role
-  meta: end_play
+  ansible.builtin.meta: end_play
   when: not has_at_least_one_ssd
 
-- name: install trim tools
-  package:
+- name: Install trim tools
+  ansible.builtin.package:
     name: util-linux
     state: present
   changed_when: false
 
-- name: edit trim periodicity if needed
-  template:
+- name: Edit trim periodicity if needed
+  ansible.builtin.template:
     src: templates/fstrim.timer.j2
     dest: "/etc/systemd/system/fstrim.timer.d/override.conf"
     owner: root
@@ -24,20 +24,20 @@
     mode: "0644"
   register: timer_config
 
-- name: systemd daemon reload
-  systemd:
-    daemon_reload: yes
+- name: Systemd daemon reload
+  ansible.builtin.systemd:
+    daemon_reload: true
   when: timer_config.changed
 
-- name: enable periodic trim
-  systemd:
+- name: Enable periodic trim
+  ansible.builtin.systemd:
     name: fstrim.timer
-    enabled: yes
+    enabled: true
     state: started
   changed_when: false
 
-- name: install nvme-cli
-  package:
+- name: Install nvme-cli
+  ansible.builtin.package:
     name: nvme-cli
     state: present
   changed_when: false